3D-Migoto 1.3.16 UNITY 2018 crash with strange shader

[Losti]

I have never seen this before but it seems that from Migoto 1.3.15 and above a UNITY game crashes by checking a strange shader for apply RegEx. If i use Migoto 1.3.14 and below, everything is fine. I could save the sahder and it falls back to ASM but also this is corrupt. Strange code line here, this is an example "r4.y = r5.x + {min16f};"

"
Performing deferred shader analysis on ps 16f00f188f530c08...
Destroying DLL...
"

The game crashes with a RUNTIME error from c++

Code: Select all

//////////////////////////////// HLSL Errors ////////////////////////////////
// D:\Games\This.Land.Is.My.Land\This.Land.Is.My.Land\ShaderFixes\16f00f188f530c08-ps_replace.txt(120,18): error X3000: syntax error: unexpected token '{'
// D:\Games\This.Land.Is.My.Land\This.Land.Is.My.Land\ShaderFixes\16f00f188f530c08-ps_replace.txt(121,10): error X3000: syntax error: unexpected token '{'
// D:\Games\This.Land.Is.My.Land\This.Land.Is.My.Land\ShaderFixes\16f00f188f530c08-ps_replace.txt(122,18): error X3000: syntax error: unexpected token '{'
// D:\Games\This.Land.Is.My.Land\This.Land.Is.My.Land\ShaderFixes\16f00f188f530c08-ps_replace.txt(123,10): error X3000: syntax error: unexpected token '{'
// D:\Games\This.Land.Is.My.Land\This.Land.Is.My.Land\ShaderFixes\16f00f188f530c08-ps_replace.txt(124,18): error X3000: syntax error: unexpected token '{'
// D:\Games\This.Land.Is.My.Land\This.Land.Is.My.Land\ShaderFixes\16f00f188f530c08-ps_replace.txt(125,10): error X3000: syntax error: unexpected token '{'
// D:\Games\This.Land.Is.My.Land\This.Land.Is.My.Land\ShaderFixes\16f00f188f530c08-ps_replace.txt(132,17): error X3000: syntax error: unexpected token '{'
// D:\Games\This.Land.Is.My.Land\This.Land.Is.My.Land\ShaderFixes\16f00f188f530c08-ps_replace.txt(133,21): error X3000: syntax error: unexpected token '{'
// D:\Games\This.Land.Is.My.Land\This.Land.Is.My.Land\ShaderFixes\16f00f188f530c08-ps_replace.txt(144,19): error X3000: syntax error: unexpected token '{'
// D:\Games\This.Land.Is.My.Land\This.Land.Is.My.Land\ShaderFixes\16f00f188f530c08-ps_replace.txt(145,22): error X3000: syntax error: unexpected token '{'
// D:\Games\This.Land.Is.My.Land\This.Land.Is.My.Land\ShaderFixes\16f00f188f530c08-ps_replace.txt(145,12-30): error X3013: 'max': no matching 0 parameter intrinsic function
// D:\Games\This.Land.Is.My.Land\This.Land.Is.My.Land\ShaderFixes\16f00f188f530c08-ps_replace.txt(145,12-30): error X3013: Possible intrinsic functions are:
// D:\Games\This.Land.Is.My.Land\This.Land.Is.My.Land\ShaderFixes\16f00f188f530c08-ps_replace.txt(145,12-30): error X3013:     max(float|half|double|min10float|min16float|int|uint|min12int|min16int|min16uint, float|half|double|min10float|min16float|int|uint|min12int|min16int|min16uint)
/////////////////////////////////////////////////////////////////////////////

This is the complete Shader saved with Migoto 1.3.14
https://losti.s3.amazonaws.com/16f00f188f530c08-ps.txt


I am using GTX 1070 (SLI disabled), an intel I9 and Windows 1909 with driver 451.67 STANDARD installed from a clean 425.31 installation with the BringBack3DV tool.

I will now clean up the driver with DDU and use 425.31 and see if this is a problem of the Driver/Hacked Driver and Win 1903.

//Also Crashing with 425.31 .. GOOD NEWS, its not a driver issue

[schwing]

Masterotaku had the same problem with RE2 I think. Take out the {min...} stuff and remove | enableMinimumPrecision. If I missed something, then he'll know.

[Losti]

Masterotaku had the same problem with RE2 I think. Take out the {min...} stuff and remove | enableMinimumPrecision. If I missed something, then he'll know.

Ill ship the fix with migoto 1.3.14 because i dont know if this is the only shader having this issue. I dont need to touch or fix it, but the RegEx check will kill the game. So ill go with 1.3.14 to be sure not having game crashes. Thanks for explaination.

But the question is: Whats different in 1.3.14 and later, that the later versions will crash?? and 1.3.14 not ? May be this can be fixed in 1.3.17 ??

[bo3bber]

Masterotaku had the same problem with RE2 I think. Take out the {min...} stuff and remove | enableMinimumPrecision. If I missed something, then he'll know.

Ill ship the fix with migoto 1.3.14 because i dont know if this is the only shader having this issue. I dont need to touch or fix it, but the RegEx check will kill the game. So ill go with 1.3.14 to be sure not having game crashes. Thanks for explaination.

But the question is: Whats different in 1.3.14 and later, that the later versions will crash?? and 1.3.14 not ? May be this can be fixed in 1.3.17 ??

Seems like that's a new change from Unity that is now using minimum precision and exposing this bug in 3Dmigoto.

I would discourage shipping with 1.3.14 as that will make the game fix incompatible with HelixVision and 3DFM which requires 1.3.16 to do the per-game driver override mechanism.

Would be worth adding as an Issue on 3Dmigoto github, as DarkStarSword will then see it.

[Losti]

hm, but if i use 1.3.16 i cant use RegEx. Means i need to add the shader fixes manually and not sure if more shaders in the game needs the things i have fixed in the first part of the game. Ill check if the shader dumping will dump ALL shaders, than this would be a workarround until the game gets an upgrade and switches shader hashes. I am not a friend of static fixed shaders, see Kingdome Comes ... I have updated the game arround 3 times because of a game update. But in my to To list is a merge of the fixes from Wolcan and KCD and write a HUGE RegEx for the damn light shader fixes. But the things i have done here are a bit uncommon.


//Not possible even if i remove the things swing suggested. Game is still crashing using migoto 1.3.16, i am forced to go with 1.3.14 currently.

[bo3bber]

@Losti: Thanks for this bug report.

Can you tell me how to reproduce this easily? The files are OK, but based on DSS discussion on github, it doesn't seem like it should be happening.

Is this an Unity game, this specific one, or a specific Regex?

If I can understand the scenario I might be able to offer a workaround.

Thanks,
bo3b

[Losti]

@Losti: Thanks for this bug report.

Can you tell me how to reproduce this easily? The files are OK, but based on DSS discussion on github, it doesn't seem like it should be happening.

Is this an Unity game, this specific one, or a specific Regex?

If I can understand the scenario I might be able to offer a workaround.

Thanks,
bo3b

Hey Bob, thank you for return back to this.

I only have had this issue with the game: This Land Is My Land
Reproduce is easy. Just copy this https://losti.s3.amazonaws.com/This.Lan ... 1.3.16.zip to the game folder. Just start the game and it should crash because of the 16f00f188f530c08-ps.txt (that was dumped out with 1.3.14). You can also uncomment the include = ShaderFixes\ShaderRegEx_GAMENAME_by_Losti.ini in the ini, the game will also crash because the shader is present. If you want to crash the game later, you can remove the shader from above from the ShaderFixes folder and leave the RegEx include. You can enter the main Menu, but if you start a new game, the game will crash again. In the d3d11_log.txt you can now see at the end "Performing deferred shader analysis on ps 16f00f188f530c08...
Destroying DLL..." Means the time migoto Checks this shader for matching a RegEx the game will crash. It issnt dependend on the RegEx. Its the "progressing" of the shader file having this things in use "max(float|half|double|min10float|min16float|int|uint|min12int|min16int|min16uint, float|half|double|min10float|min16float|int|uint|min12int|min16int|min16uint)"